Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to C++14 #902

Merged
merged 1 commit into from
Feb 28, 2023
Merged

move to C++14 #902

merged 1 commit into from
Feb 28, 2023

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Feb 24, 2023 •
edited
Loading

Closes #602

@sergiud sergiud added this to the 0.7 milestone Feb 24, 2023
@sergiud sergiud mentioned this pull request Feb 24, 2023
Closed
@sergiud sergiud requested a review from drigz February 24, 2023 22:15
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.99103% with 58 lines in your changes missing coverage. Please review.

Project coverage is 73.85%. Comparing base (a13d03b) to head (389ae5c).
Report is 154 commits behind head on master.

Files with missing lines Patch % Lines
src/windows/dirent.h 33.33% 20 Missing ⚠️
src/logging.cc 84.82% 17 Missing ⚠️
src/signalhandler.cc 18.18% 9 Missing ⚠️
src/utilities.cc 63.63% 4 Missing ⚠️
src/symbolize.cc 66.66% 3 Missing ⚠️
src/vlog_is_on.cc 76.92% 3 Missing ⚠️
src/glog/logging.h.in 50.00% 1 Missing ⚠️
src/windows/port.cc 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
- Coverage   73.97%   73.85%   -0.13%     
==========================================
  Files          17       17              
  Lines        3282     3251      -31     
==========================================
- Hits         2428     2401      -27     
+ Misses        854      850       -4
Files with missing lines Coverage Δ
src/base/googleinit.h 100.00% <ø> (ø)
src/base/mutex.h 100.00% <100.00%> (ø)
src/demangle.cc 97.47% <100.00%> (-0.02%) ⬇️
src/glog/stl_logging.h.in 100.00% <100.00%> (ø)
src/raw_logging.cc 100.00% <ø> (ø)
src/stacktrace_unwind-inl.h 92.59% <100.00%> (ø)
src/utilities.h 100.00% <100.00%> (ø)
src/windows/port.h 100.00% <100.00%> (ø)
src/glog/logging.h.in 80.28% <50.00%> (+0.28%) ⬆️
src/windows/port.cc 54.54% <80.00%> (ø)
... and 6 more

@sergiud sergiud merged commit 6742834 into master Feb 28, 2023
@sergiud sergiud deleted the drop-c++98 branch February 28, 2023 11:26
@Porkepix Porkepix mentioned this pull request Feb 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drigz drigz drigz approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

Any plan to set c++11 as default standard version?
3 participants
@sergiud @codecov-commenter @drigz